Prevented user enumeration of valid users through HTTP status codes of login (#3639) (#3654)

2016-10-17 10:08:40 +08:00 · 2016-10-17 10:08:40 +08:00 · 2cb5ec5983
parent 2bec8a4f1e
commit 2cb5ec5983
1 changed files with 4 additions and 2 deletions
--- a/routers/user/auth.go
+++ b/routers/user/auth.go
@ -341,8 +341,10 @@ func ForgotPasswdPost(ctx *context.Context) {
 	u, err := models.GetUserByEmail(email)
 	if err != nil {
 		if models.IsErrUserNotExist(err) {
-			ctx.Data["Err_Email"] = true
-			ctx.RenderWithErr(ctx.Tr("auth.email_not_associate"), FORGOT_PASSWORD, nil)
+			ctx.Data["Hours"] = setting.Service.ActiveCodeLives / 60
+			ctx.Data["IsResetSent"] = true
+			ctx.HTML(200, FORGOT_PASSWORD)
+			return
 		} else {
 			ctx.Handle(500, "user.ResetPasswd(check existence)", err)
 		}